Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkstyle issues due to mynah UI fixes #369

Conversation

taldekar
Copy link
Contributor

Description of changes:

  • Break large function into smaller functions.
  • Use string selectors to prevent wrong resolutions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@taldekar taldekar changed the base branch from main to taldekar/blockArrowKeysInChatPrompt February 17, 2025 17:32
@taldekar taldekar changed the title Fix checkstyle issues due to mynah UI Fix checkstyle issues due to mynah UI fixes Feb 17, 2025
@taldekar taldekar merged commit 1c5793e into taldekar/blockArrowKeysInChatPrompt Feb 18, 2025
1 check passed
@taldekar taldekar deleted the taldekar/MynahUIFixCheckstyleIssues branch February 18, 2025 17:49
taldekar added a commit that referenced this pull request Feb 20, 2025
* Disable arrow keys if text area is empty

* Fix unrelated changes introduced by stash apply

* Support select all and copy shortcuts in chat (#353)

* Support select all and copy keyboard shortcuts in chat

* Fix submitted code block cancel button (#354)

* Fix submitted code block cancel button

* Fix empty overflow bubble (#356)

* Fix empty pop-up when no overflow in follow up question text

* Fix accidentally removed copy event listener

* Fix checkstyle issues

* Fix Mynah UI checkstyle issues (#369)

* Undo unintended manifest change
taldekar added a commit that referenced this pull request Feb 20, 2025
* Disable arrow keys if text area is empty

* Fix unrelated changes introduced by stash apply

* Support select all and copy shortcuts in chat (#353)

* Support select all and copy keyboard shortcuts in chat

* Fix submitted code block cancel button (#354)

* Fix submitted code block cancel button

* Fix empty overflow bubble (#356)

* Fix empty pop-up when no overflow in follow up question text

* Fix accidentally removed copy event listener

* Fix checkstyle issues

* Fix Mynah UI checkstyle issues

* Fix Mynah UI checkstyle issues (#369)

* Fix code block cancel button in mynah

* Fix mynah UI progress indicator (#374)

* Fix progress indicator not disappearing after complete result has streamed

* Fix Amazon Q progress spinner bug (#376)

* Fix mynah show more icon (#377)

* Fix progress indicator not disappearing after complete result has streamed

* Fix Amazon Q progress spinner bug

* Fix show more icon in MynahUI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants